Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #799: valuetext doesn't update #885

Merged
merged 2 commits into from
Dec 8, 2018

Conversation

jespirit
Copy link
Collaborator

@jespirit jespirit commented Dec 2, 2018

Fixes #799

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • Link to original Github issue (if this is a bug-fix)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

Fix: Destroy accessibility slider from previous test
Copy link
Collaborator

@rovolution rovolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jespirit you are doing great work with these PRs and reviews!

Thank you very much! Very happy to see other people step up and take an active role in helping manage the slider.

}
return dayOfWeek[value-1];
};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good tests!!!!

@jespirit jespirit merged commit f5a6f97 into seiyria:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

valuetext doesn't update when formatted value is number-like
2 participants